Open the samples page from the home page, and drop the page about it - #168
Merged
Conversation
resources/samples.md described three catalogues it does not own: what each holds, how many apps that is, how to read a row, how to run one. All of it is already on the pages themselves, which carry the search, the filters and a bar linking the other two - so the page here was a stop between the reader and the corpus, and a second copy of four figures somebody else maintains. The home page button now opens https://abap2ui5.github.io/samples/ directly. The four pages that pointed at the removed page name the three catalogue pages instead, and the sidebar entry is gone. check:counts existed only to hold those four figures against the catalogues. With the prose copy gone there is nothing left to check, so the gate and scripts/check-corpus-counts.mjs go with it - six gates become five in package.json, both workflows, AGENTS.md and README.md. scripts/lib/catalogue.mjs stays: link-samples.mjs parses with it and generate-llms.mjs still counts the three catalogues into llms.txt, which is why CI keeps the two sparse checkouts. Verified: npm run check green, all five, with an abap2UI5/samples checkout so check:samples reported rather than skipped. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fqonz6wkm3wGyER57qNwGE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resources/samples.mddescribed three catalogues it does not own: what each holds, how many apps that is, how to read a row, how to run one. All of it is already on the pages themselves, which carry the search, the filters and a bar linking the other two — so the page here was a stop between the reader and the corpus, and a second copy of four figures somebody else maintains.What changes
docs/resources/samples.mdis deleted, together with its sidebar entry under Resources.get_started/next.md,get_started/tooling.md,advanced/vscode.md,advanced/mcp_server.md— name the three catalogue pages instead.One gate less
check:countsexisted only to hold the four figures on that page against the catalogues. With the prose copy gone there is nothing left to check, so the gate andscripts/check-corpus-counts.mjsgo with it — six gates become five inpackage.json,check.yml,deploy.yml,AGENTS.md,README.mdandCLAUDE.md.scripts/lib/catalogue.mjsand its test stay:link-samples.mjsparses with it andgenerate-llms.mjsstill counts the three catalogues intollms.txt— which is why CI keeps the two sparse checkouts ofSAMPLES.md, with the comment above them rewritten to say what they are actually for now.Verified
npm run checkgreen, all five.check:sampleswas run against a realabap2UI5/samplescheckout so it reported rather than skipped — 150 samples, 39 pages, 109 links, up to date. The build has no dead internal links, andresources/samples.htmlis gone from the dist and fromllms.txt.Generated by Claude Code